
Find Me On Discord (Brood War UMS Community & Staredit Network)
I think because SCBW is really old with a small playerbase you can get away with basically anything. Which is refreshing because "art" really should not have any constraints. I mean if you really think about it so many UMS is "illegal" according to copyright law. Any LOTR maps, didn't get permission to use the LOTR licence - illegal. Resident Evil - illegal. Etc. But really you should not be asking is it legal or illegal but can I get away with it, and in SCBW I believe you can. Where do you draw the line? If you draw a picture of Aragorn, is that breaching copyright? If you take a photo of that picture and sell it to a bunch of people, is that breaching copyright? If you rename a Terran Marine to Aragorn, is that breaching copyright? If you make an entire SC map based around the adventures of Aragorn, is that breaching copyright? In many ways it's a ridiculous law. But the law itself, the spirit of it, it's important, because there are artists out there that get ripped off from their creations, and this law is trying to protect them. So it's a good thing, but it's not perfect by any stretch and has a lot of issues, IMO.
I have ripped so many SFX from movies, TV shows, and games, it's not funny. I use Audacity and stereo mix like you do to record the sounds then bam in they go. Sometimes I layer multiple sounds together from different sources. With video games I just go into the game, mute everything (music, ambience, voice acting) to isolate the sounds. Gun sounds and reload sounds you can often find compilations of them on Youtube and lift them from there.
As for music, I think you can get away with pretty much anything, but you will notice if you use copywritten music, anyone playing your map and streaming it on Youtube or Twitch or something it will get flagged that way. But that's just the video being flagged of course, not the map itself. That could potentially be traced back to you, but as long as your username is sufficiently disconnected from your real life name it's not like you could ever be prosecuted. I guess if someone was really determined to sue you they could trace your IP or something... extremely unlikely.
For music I tend to take music from video games. As JJ said if you take it from Blizzard that's pretty safe. But other video games I've taken from over the years and the reason I prefer video games is they seem to not fall under the same copyright protections. Note I said protections not laws. I'm sure it's still completely illegal but, no doubt for practicality reasons, copyright flagging software on Youtube etc never seems to detect video game music. I believe because if it did it would actively discourage people showing off the game which is not what game developers want.
I think if you try to do patreon bs or paypal, start trying to profit off it, that's when you're more likely to get in trouble, because money is involved. You have to remember, for most companies it is not a moral issue, it is a monetary issue. If the chance of making money off of suing you is next to nothing, they will have no incentive to hire lawyers to pursue you.
TLDR: Is it illegal? Yes. But I have never personally heard anyone getting sued before in this little corner of the web. I would be interested to know more about this DMCA on a SC1 map though. I've never heard of it.