I wonder if someone tried to create a new spell this way. What I have in mind is basically a piece of code executed when a unit uses a weapon with certain id to produce a different effect. I think this would prevent consuming existing spells. My knowledge of C++ is almost non-existent, but I hope someone with more experience would carry on idea.
And there is my experiment. I tried to add blink spell, the one that Stalkers in SC2 have.
1)Added ensnare button to dragoon's button set.
2)Put useweapon 117 instead of castspell opcode in dragoon's icript inside the DragoonCastSpell section.
3)Set unused weapon's no 117 targeting to terrain in weapons.dat.
4)Added this abomination into weapon_fire.cpp
When I used the ensnare button nothing besides creating an arclite shock cannon hit effect on the ground happened. So I just made dragoon attack normally and that's when the weird shit started to happen.
https://www.youtube.com/watch?v=9XoRKs1T1Oc&feature=youtu.be
If anyone could help me with making dragoons blink I'd be grateful. The perfect way for me would be blink using 0 energy but having a few seconds delay (probably using unusedTimer would make this possible).

Attachments:

I assume you also edited ensnare's tech use requirements in Firegraft, as using the blink button actually does something?

As the code you posted says:

Useweapon just spawns the bullet at the target position, skipping the code entirely. You would have to either hook the useweapon function or give the dragoon weapon 117 as second weapon and use attackwith instead.

I don't think this does anything (without additional code editing). Bw just thinks the dragoon is casting ensnare, and uses its targeting flags/energy/order/etc.


Moving units properly is far more complicated than that. There are several variables which contain unit's coordinates and they all have to be set. Also unit's pathing state has to be resetted and so on.
You can add the following function, which calls the bw's unit moving code. It should work, but it moves the unit whether or not it actually has space there.. (Disclaimer: I didn't actually test anything; 1.16.1 only)


I'm not sure where the code that reduces energy is, but you'd have to find it and modify it. Or a messier solution could just set dragoons to have max energy always and figure out a way to make them immune to feedback?

That's not really a messier solution. All units have energy, making them spellcasters in units.dat just makes the energy amount visible under unit's wireframe. I believe feedback just checks if target is a spellcaster to determine if it can be used on it or not. All I'd have to do would be refilling dragoon's energy after it's created and after every use of blink.

For teleportation, this should work:
scbw::moveUnit(unit, unit->orderTarget.pt.x - 20, unit->orderTarget.pt.y);

//if (unit->unusedTimer = 0) should be //if (unit->unusedTimer == 0)

//if (weapons_dat::Weapon[weaponId] == 117); should be //if (weaponId == 117);

Did you also put some code somewhere else to decrease the unusedTimer over time?

Nope, but I'll probably abandon the idea and do something like if unit->mainOrderId is ensnare order then teleport unit to orderTarget. I'm kinda busy right now, so I can't work on my mod for a little while, but I'll post when I'll progress with it or have problems. Maybe I'll just steal the code from here http://www.modcrafters.com/forum/viewtopic.php?f=17&t=211.
@edit
I think I'm almost there.
https://www.youtube.com/watch?v=kbtvU6_Xf3A&feature=youtu.be
I put back the castspell opcode into dragoon's iscript. The cool thing is that it's blocked by fog of war now, exactly how I wanted. Now I need to add timer to it and make SC return "Cooldown is active" if it =/= 0, maybe even change dragoon's buttonset during cooldown to show blink as disabled or something. And of course remove the ensnare bullet and effect.

Post has been edited 2 time(s), last time on Dec 2 2015, 11:37 pm by Eisetley.

I decided to sacrifice ensnare but it was totally worth it.

The only issue would be the timer (unusedTimer), because it's u8 so I can't make it any higher than 255, and I can't make a loop that would decrease the timer slower than 1 per frame. Maybe someone will help me. The only idea I had was to double the time this way: decrease unusedTimer if elapsedFrames/2 is integer.

weaponfire.cpp


game_hooks.cpp inside bool nextFrame()

For weaponfire.cpp, I would see it more like this:



What I did:
-removed the repetition of tests by putting unit->unusedTimer test as a if/else inside the common test
-put a more proper "return to idle" action (for it to be more compatible with multiplayer/replay)
-removed the line that saved an unit target (since it's unused)

I wonder if the current code would allow an exploit where you make the dragoon fire, and while it's firing, you can use the blink ability with unlimited range.

I don't think so, it always uses ensnare targeting I think. I'll test your code today, thank you.