Hi!

I was working with assembly line and found this lines:



Are they equivalent to the following?



And, how i should add this in GPTP?

I was thinking in:


And add "injectExperimental_0047B3E0()" to "initialize.cpp", but that didn't work.

Thanks!
KYSXD

Post has been edited 1 time(s), last time on May 28 2016, 8:33 pm by KYSXD.

Since the function at 0047B3E0 takes the input unit in eax, but you can't represent that in C code, you'll have to write a wrapper for it like so:



And then do jmpPatch(func0047B3E0_Wrapper, 0x0047B2E0, 0);

I never use switch, but shouldn't it be "default:" (like the "case" format)?
For the wrapper, it would be:
and for the jump patch: "jmpPatch(func0047B2E0_Wrapper, 0x0047B2E0, 3);"
But you can just not add the 3 (the point of filling that is that if somebody memory edit the modded Starcraft, he won't see weird instructions born from half-cut assembly instructions, thanks to "nop" instructions filling the gap).

edit: fixed the fact that sometimes it was written 3E0 and sometimes 2E0 (2E0 being the correct way).
Also, if you just returned a value based on the result of unit->isFactory(), you could choose what's a factory or not with a dat editor.
And finally, in your switch, you wrote Necus instead of Nexus (but I guess VS would help you fix this kind of mistake)

Post has been edited 1 time(s), last time on Apr 25 2016, 11:18 am by UndeadStar.

You can use __fastcall, or is that ECX?

Thanks, Neiv, it worked fine. I'll have to remember that for future works.

UndeadStar, I corrected all those problems, thanks. The main reason i started that was to practice assembly line convertion, i found those lines and thought them could be easy to start.

Working with some functions i almost achieve a full 640x480 game layer render, but i got some troubles with some functions.

Without modifications or patch, starcraft's behaviour looks like this:



After patch:



I didn't convert all the assembler to C++ functions, just changed some values that 'make sense' to me.

The only problems i got are with these functions (Names from heinermann's Broodwar mapping):

(Patch on these causes to 'repeat' the terrain from the top of the screen, in the place where the black section is)
0x0040C200 - BlitToBitmap
0x0040C253 - blitTileCache
0x0040C2BD - BlitTerrainCacheToGameBitmap

(Patch on this causes crash when any sprite tries to load mirror directions)
0x004D57B0 - CImage__updateGraphicData

(Patch on this causes the gradient on the bottom of the screen)
0x004808E0 - updateAllFog

I'd like to understand what those functions are doing in order to know what changes i should make, but my conversion skills aren't good (I tried a few times, but i get lost eventually)

Could anyone translate these functions to C code?

Not entirely accurate, but draws the game tiles correctly (in a separate SDL window): https://github.com/bwapi/bwapi/blob/SDL-Experiment/bwapi/BWAPI/GameRender.cpp

EDIT: That code doesn't use a cache like Starcraft does because it's not 1998 anymore.

Post has been edited 1 time(s), last time on May 29 2016, 8:34 am by Heinermann.

Wow! I'll take a look on it. Thanks!

I have a piece of code I'm currently keeping in assembly because I don't get what it does exactly.
Maybe it's an optimization of an easy manipulation, so I will share it here in case somebody get what it's doing and can explain:



edit: I'm especially confused with the XOR.The objective of course is to get a C code doing the same thing in a more readable way.
edit2: thank you for your help

Post has been edited 1 time(s), last time on Oct 25 2016, 7:04 am by UndeadStar.

It's ternary operator optimized to have no jump instructions, which is usually the case when you see things like SETB (which sets the specified register to 1 if the condition is true, otherwise sets it to 0)

It seems to be doing unitToLoad->pathingFlags = (elevationLevel < 0xC) ? pathingFlags | 1 : pathingFlags & ~1;
Basically setting flag 0x1 if elevationLevel < 12 an clearing it otherwise.

Post has been edited 1 time(s), last time on Oct 20 2016, 3:00 pm by FaRTy1billion.