Staredit Network > Forums > Modding Discussion > Topic: Problems with Current Modding Tools
Problems with Current Modding Tools
Mar 4 2015, 3:49 am
By: Sand Wraith
Pages: < 1 2 3 4 523 >
 

Apr 1 2015, 6:37 am O)FaRTy1billion[MM] Post #41

👻 👾 👽 💪

Quote
[12:18 am] poiuy_qwert -- FaRTy1billion can you put any errors and the name of the bin file or other info into this thread: http://www.staredit.net/topic/16686/
I don't remember what I did .. I just opened one bin file, then another and then change the palette around.. I think the error was in relation to that, but I can't recreate it. It may very well have just been from the way I was trying to run it trying to get 2.7 to work.

Quote
[12:19 am] poiuy_qwert -- FaRTy1billion I don't see that behaviour? can you give more details and steps to reproduce in that same thread?
I was just trying to see if I could figure out anything that would cause the problem you were having with text alignment in the campaign menu ...

When I open the glucmpgn, I see:


If I open the properties window and close it (making no changes), the green rectangle is changed to:


I was just suggesting the text alignment issue may be related to a miscalculation of the white textbox size (or perhaps a missing variable or property or something), but that's just a guess.



TinyMap2 - Latest in map compression! ( 7/09/14 - New build! )
EUD Action Enabler - Lightweight EUD/EPD support! (ChaosLauncher/MPQDraft support!)
EUDDB - topic - Help out by adding your EUDs! Or Submit reference files in the References tab!
MapSketch - New image->map generator!
EUDTrig - topic - Quickly and easily convert offsets to EUDs! (extended players supported)
SC2 Map Texture Mask Importer/Exporter - Edit texture placement in an image editor!
\:farty\: This page has been viewed [img]http://farty1billion.dyndns.org/Clicky.php?img.gif[/img] times!

Apr 1 2015, 10:08 pm Neiv Post #42



PyTBL (Well, I guess all of the tools) happily places its window outside the desktop area if its settings file has saved such coordinates, which can happen when switching monitor setup. Of course I can just edit the settings file every time I disconnect my second monitor, but it could become somewhat annoying when there are 10+ files to edit. Is there an easy way to detect when window would appear entirely out of desktop area and force it inside?



None.

Apr 2 2015, 12:08 am poiuy_qwert Post #43

PyMS and ProTRG developer

Quote from O)FaRTy1billion[MM]
I don't remember what I did .. I just opened one bin file, then another and then change the palette around.. I think the error was in relation to that, but I can't recreate it. It may very well have just been from the way I was trying to run it trying to get 2.7 to work.
Could be because I work on cleanup related stuff after I finish things still in dev. While its still in dev I would open one file per launch.

Quote
When I open the glucmpgn, I see:


If I open the properties window and close it (making no changes), the green rectangle is changed to:
Interesting. I don't think this is affecting the text alignment but its a bug either way.
Edit: This was a result of the automatic calculations that happen when you type also being run when the fields were set programmatically while loading the dialog. Fixed now.

Quote from Neiv
PyTBL (Well, I guess all of the tools) happily places its window outside the desktop area if its settings file has saved such coordinates, which can happen when switching monitor setup. Of course I can just edit the settings file every time I disconnect my second monitor, but it could become somewhat annoying when there are 10+ files to edit. Is there an easy way to detect when window would appear entirely out of desktop area and force it inside?
I've rewritten the window size loading so this should no longer happen.

Thanks for the reports!

Post has been edited 1 time(s), last time on Apr 2 2015, 1:34 am by poiuy_qwert.




Apr 2 2015, 9:21 am Neiv Post #44



Since commit 67d739b the string editing field in PyTBL is created minimally thin and has to be resized.
Also could there be a way to jump to a string by its index?
Aaalso when pressing Ctrl-F to search for a string, it would make sense to have the text field selected so I could just Ctrl-F => Write text => Enter without using mouse.
And esc as a hotkey to close search window?
And maybe there could be checkbox for wrapping around when searching?



None.

Apr 2 2015, 4:00 pm poiuy_qwert Post #45

PyMS and ProTRG developer

Quote from Neiv
Since commit 67d739b the string editing field in PyTBL is created minimally thin and has to be resized.
Fixed

Quote from Neiv
Also could there be a way to jump to a string by its index?
I can add that.

Quote from Neiv
Aaalso when pressing Ctrl-F to search for a string, it would make sense to have the text field selected so I could just Ctrl-F => Write text => Enter without using mouse.
Fixed

Quote from Neiv
And esc as a hotkey to close search window?
Added

Quote from Neiv
And maybe there could be checkbox for wrapping around when searching?
Added


Thanks for the reports!




Apr 4 2015, 11:19 pm Neiv Post #46



Quote from poiuy_qwert
Quote from Neiv
Aaalso when pressing Ctrl-F to search for a string, it would make sense to have the text field selected so I could just Ctrl-F => Write text => Enter without using mouse.
Fixed
I still have to click with mouse after having done one search.

Also, I complained a week or two ago in shoutbox how PyTBL can't handle characters outside of the 128 ascii characters properly, but it didn't happen on your system.. I came up with this patch to fix it though I have no idea if it breaks something on other systems.
Code
diff --git a/Libs/TBL.py b/Libs/TBL.py
index 9c0679e..e83e9e6 100755
--- a/Libs/TBL.py
+++ b/Libs/TBL.py
@@ -126,7 +126,7 @@ class TBL:
            for i in xrange(len(offsets)):
                o = offsets[i]
                l = lengths[o]
-                 strings.append(data[o:o+l])
+                 strings.append(unicode(data[o:o+l], 'cp1252'))
            self.strings = strings
        except:
            raise PyMSError('Load',"Unsupported TBL file '%s', could possibly be corrupt" % file)
@@ -160,7 +160,7 @@ class TBL:
            if not s.endswith('\x00'):
                s += '\x00'
            header += struct.pack('<H', o)
-             data += bytearray(s, 'utf-8')
+             data += bytearray(s, 'cp1252')
            o += len(s)
        f.write(header + data)
        f.close()


Some PyDAT issues:
-Open directory does not actually open units.dat? The filename on bottom changes but unit stats don't.
-Ctrl-D and Ctrl-Alt-O give errors
-Ctrl-F selects se search field but could it also select the search string there so it gets deleted after writing something?
-This seems to be more of python ui limitation, but is it possible to allow typing letters when dropdown listbox is selected to search for a specific entry?

Edit: Is there any reason why the placement box is located at staredit tab instead of being next to unit dimensions? Sure, Datedit does it too (And Arsenal 3 as well?), but it is really misleading place for it as it is used for the building placement size and such in-game. Also it's existence is easy to forget when changing unit dimensionbox <.<

Edit2: The dimension box preview seems to be off by one pixel. Even if the dimension box is (0, 0, 0, 0) the unit will use 1x1 pixel space, unit with (3, 2, 2, 2) box will use 6x5 pixels and so on. Most of the units have same sized dimension and placement boxes, but the previewer shows dimension box smaller.

Edit3: The sound tab is completely incorrect.

Thanks for the continuous updates <3

Post has been edited 4 time(s), last time on Apr 5 2015, 7:36 am by Neiv.



None.

Apr 5 2015, 6:49 am Corbo Post #47

ALL PRAISE YOUR SUPREME LORD CORBO

PyMS icons were bugging me (No offense, poiuy). I didn't like them and it disturbed my workflow :P

And being that I am Corbo and like to change stuff in other people's tools I decided to make some new icons and decided to share them with you guys. I didn't make ALL of them, I am missing the saving ones, but it is pleasant enough for me to work now. My problem was that they were too... "off".


I could make saving ones too if anyone is interested, otherwise, here you go:
http://www.mediafire.com/download/l7c2041b875vd87/PyMS_Icons.zip


A few screenshots:





fuck you all

Apr 5 2015, 2:15 pm A_of-s_t Post #48

aka idmontie

I forked the PyMS repo and added in your images, Corbo. If this look good, I can issue a pull request back to the original repo with your images.

Here's the repo.



Personal GitHub
Starcraft GitHub Organization - Feel free to request member status!
TwitchTV

Apr 6 2015, 3:15 am poiuy_qwert Post #49

PyMS and ProTRG developer

Quote from Neiv
...
I'll look into these soon, thanks!

Quote from Corbo
PyMS icons were bugging me (No offense, poiuy). I didn't like them and it disturbed my workflow :P

And being that I am Corbo and like to change stuff in other people's tools I decided to make some new icons
Yeah I stopped caring much about the icons somewhere along the way :( But thats one reason PyMS is open source, edit them to your liking!

Quote from A_of-s_t
I forked the PyMS repo and added in your images, Corbo. If this look good, I can issue a pull request back to the original repo with your images.
I wouldn't merge this into the main PyMS repo unless it was a complete and cohesive icon set. It also doesn't fit the style that I am looking for.




Apr 6 2015, 3:17 am A_of-s_t Post #50

aka idmontie

Quote from poiuy_qwert
I wouldn't merge this into the main PyMS repo unless it was a complete and cohesive icon set. It also doesn't fit the style that I am looking for.

They are a little gray, aren't they?

Also, am I supposed to use a specific versions of Python? Most of the applications work in Python 2.7, but pyDAT crashes on me when I try to run it.



Personal GitHub
Starcraft GitHub Organization - Feel free to request member status!
TwitchTV

Apr 6 2015, 4:13 am poiuy_qwert Post #51

PyMS and ProTRG developer

Quote from A_of-s_t
Also, am I supposed to use a specific versions of Python? Most of the applications work in Python 2.7, but pyDAT crashes on me when I try to run it.
You only need Python 2.6+ for most programs, you need PIL for any program that display images (other than icons), and to work with MPQ's you need to be running in 32-bit mode. Best bet to fix the issue is to get me the crash log. Check PyMS/Libs/stdeo.txt if there are no error dialogs or tracebacks on the command line.




Apr 16 2015, 2:27 am poiuy_qwert Post #52

PyMS and ProTRG developer

Quote from Neiv
I still have to click with mouse after having done one search.
Fixed.

Quote from Neiv
Also, I complained a week or two ago in shoutbox how PyTBL can't handle characters outside of the 128 ascii characters properly, but it didn't happen on your system..
In certain circumstances it would happen on my system so I did change some stuff and it was working for me. I made the changes you did but with the latin-1 encoding for cross platform, hopefully it works for you.

Quote from Neiv
Open directory does not actually open units.dat? The filename on bottom changes but unit stats don't.
Fixed

Quote from Neiv
-Ctrl-D and Ctrl-Alt-O give errors
Ctrl+D is fixed, wasn't getting any issues with Ctrl+Alt+O though

Quote from Neiv
-Ctrl-F selects se search field but could it also select the search string there so it gets deleted after writing something?
Done

Quote from Neiv
-This seems to be more of python ui limitation, but is it possible to allow typing letters when dropdown listbox is selected to search for a specific entry?
Yeah.. I'll see what I can do

Quote from Neiv
Is there any reason why the placement box is located at staredit tab instead of being next to unit dimensions? Sure, Datedit does it too (And Arsenal 3 as well?), but it is really misleading place for it as it is used for the building placement size and such in-game. Also it's existence is easy to forget when changing unit dimensionbox <.<
Don't know, but for consistency I'm not going to change it.

Quote from Neiv
The dimension box preview seems to be off by one pixel. Even if the dimension box is (0, 0, 0, 0) the unit will use 1x1 pixel space, unit with (3, 2, 2, 2) box will use 6x5 pixels and so on. Most of the units have same sized dimension and placement boxes, but the previewer shows dimension box smaller.
I tweaked the preview, I believe its better.

Quote from Neiv
Edit3: The sound tab is completely incorrect.
Fixed.

Thanks for the reports.




Apr 18 2015, 2:04 am Neiv Post #53



This is the error I get with Ctrl-Alt-O:
Exception in Tkinter callback
Traceback (most recent call last):
File "C:\Ohjelmia\Python27\lib\lib-tk\Tkinter.py", line 1532, in __call__
return self.func(*args)
TypeError: openmpq() takes exactly 1 argument (2 given)
Exception in Tkinter callback
Traceback (most recent call last):
File "C:\Ohjelmia\Python27\lib\lib-tk\Tkinter.py", line 1532, in __call__
return self.func(*args)
TypeError: openmpq() takes exactly 1 argument (2 given)



None.

Apr 18 2015, 2:21 am poiuy_qwert Post #54

PyMS and ProTRG developer

Quote from Neiv
This is the error I get with Ctrl-Alt-O:
Exception in Tkinter callback
Traceback (most recent call last):
File "C:\Ohjelmia\Python27\lib\lib-tk\Tkinter.py", line 1532, in __call__
return self.func(*args)
TypeError: openmpq() takes exactly 1 argument (2 given)
Exception in Tkinter callback
Traceback (most recent call last):
File "C:\Ohjelmia\Python27\lib\lib-tk\Tkinter.py", line 1532, in __call__
return self.func(*args)
TypeError: openmpq() takes exactly 1 argument (2 given)
Fixed thx




May 17 2015, 11:44 am Neiv Post #55



Some pygrp issues:
1) Opening grp and importing vertical bmp containing more frames causes the following error:
Code
Exception in Tkinter callback
Traceback (most recent call last):
 File "C:\Ohjelmia\Python27\lib\lib-tk\Tkinter.py", line 1532, in __call__
   return self.func(*args)
 File "C:\Pelei\Scbw\Ohjelmia\PyMS\PyGRP.pyw", line 776, in imports
   self.preview()
 File "C:\Pelei\Scbw\Ohjelmia\PyMS\PyGRP.pyw", line 553, in preview
   self.frameoutline()
 File "C:\Pelei\Scbw\Ohjelmia\PyMS\PyGRP.pyw", line 528, in frameoutline
   x1,y1,x2,y2 = self.grp.images_bounds[frame]
IndexError: list index out of range

(Deleting all frames before importing avoids it)

2) Saving grp causes another crash:
Code
Exception in Tkinter callback
Traceback (most recent call last):
 File "C:\Ohjelmia\Python27\lib\lib-tk\Tkinter.py", line 1532, in __call__
   return self.func(*args)
 File "C:\Pelei\Scbw\Ohjelmia\PyMS\PyGRP.pyw", line 683, in save
   self.grp.save_file(self.file)
 File "C:\Pelei\Scbw\Ohjelmia\PyMS\Libs\GRP.py", line 457, in save_file
   f.close()
 File "C:\Pelei\Scbw\Ohjelmia\PyMS\Libs\utils.py", line 1447, in close
   raise e
WindowsError: [Error 183] Cannot create file, already exists

Nvm, another program didn't let it save

3) Grps are encoded inefficiently: Every non-transparent color is encoded as [repeat this color for n pixels], even if there are no vertical lines of repeated colors. Not too huge deal but happened to notice it

Edit: 4) Opening and saving again loses the last row/column of each frame

Post has been edited 2 time(s), last time on May 17 2015, 3:32 pm by Neiv.



None.

May 24 2015, 1:33 am poiuy_qwert Post #56

PyMS and ProTRG developer

Quote from Neiv
Some pygrp issues:
1) Opening grp and importing vertical bmp containing more frames causes the following error:
Code
Exception in Tkinter callback
Traceback (most recent call last):
 File "C:\Ohjelmia\Python27\lib\lib-tk\Tkinter.py", line 1532, in __call__
   return self.func(*args)
 File "C:\Pelei\Scbw\Ohjelmia\PyMS\PyGRP.pyw", line 776, in imports
   self.preview()
 File "C:\Pelei\Scbw\Ohjelmia\PyMS\PyGRP.pyw", line 553, in preview
   self.frameoutline()
 File "C:\Pelei\Scbw\Ohjelmia\PyMS\PyGRP.pyw", line 528, in frameoutline
   x1,y1,x2,y2 = self.grp.images_bounds[frame]
IndexError: list index out of range

(Deleting all frames before importing avoids it)
I'll look into it

Quote from Neiv
3) Grps are encoded inefficiently: Every non-transparent color is encoded as [repeat this color for n pixels], even if there are no vertical lines of repeated colors. Not too huge deal but happened to notice it

Edit: 4) Opening and saving again loses the last row/column of each frame
Hmm this sounds like it may be due to the large changes i've made to the grp handling recently. Previously I worked hard to make sure PyGRP was the best at compressing GRP's, its sad to hear that I broke that :(


Thanks, hopefully I'll have time to look into these soon.




Oct 7 2015, 8:34 am Sand Wraith Post #57

she/her

PyGRP: Having problems with importing Single BMP Vertical framesets:

Code
Exception in Tkinter callback
Traceback (most recent call last):
 File "C:\Python27\lib\lib-tk\Tkinter.py", line 1536, in __call__
   return self.func(*args)
 File "D:\Libraries\Gaming\StarCraft_Content\Customs\Tools\PyMS\PyGRP.pyw", line 776, in imports
   self.preview()
 File "D:\Libraries\Gaming\StarCraft_Content\Customs\Tools\PyMS\PyGRP.pyw", line 553, in preview
   self.frameoutline()
 File "D:\Libraries\Gaming\StarCraft_Content\Customs\Tools\PyMS\PyGRP.pyw", line 528, in frameoutline
   x1,y1,x2,y2 = self.grp.images_bounds[frame]
IndexError: list index out of range


Additionally, while I was working with a *.grp:

1) I opened the grp file ORIGINAL. (ORIGINAL happens to be Kakaru, neutral critter in Twilight, the bird thing.)
2) I deleted every frame except for its death animation, from top to bottom in the frame list using keyboard shortcut DELETE.
3) I used SAVE AS to save to file OUT.
4) Expected output: file OUT retains remaining frames (death animation) and frames are complete. Actual output: file OUT retains remaining frames but frames are not complete: frames have been cropped according to the limits drawn in the file ORIGINAL and by the "Frame Outline (Red)" feature.




Oct 19 2015, 7:45 am poiuy_qwert Post #58

PyMS and ProTRG developer

Quote from Neiv
Some pygrp issues:
1) Opening grp and importing vertical bmp containing more frames causes the following error:
Code
Exception in Tkinter callback
Traceback (most recent call last):
 File "C:\Ohjelmia\Python27\lib\lib-tk\Tkinter.py", line 1532, in __call__
   return self.func(*args)
 File "C:\Pelei\Scbw\Ohjelmia\PyMS\PyGRP.pyw", line 776, in imports
   self.preview()
 File "C:\Pelei\Scbw\Ohjelmia\PyMS\PyGRP.pyw", line 553, in preview
   self.frameoutline()
 File "C:\Pelei\Scbw\Ohjelmia\PyMS\PyGRP.pyw", line 528, in frameoutline
   x1,y1,x2,y2 = self.grp.images_bounds[frame]
IndexError: list index out of range

(Deleting all frames before importing avoids it)
Quote from Sand Wraith
PyGRP: Having problems with importing Single BMP Vertical framesets:

Code
Exception in Tkinter callback
Traceback (most recent call last):
 File "C:\Python27\lib\lib-tk\Tkinter.py", line 1536, in __call__
   return self.func(*args)
 File "D:\Libraries\Gaming\StarCraft_Content\Customs\Tools\PyMS\PyGRP.pyw", line 776, in imports
   self.preview()
 File "D:\Libraries\Gaming\StarCraft_Content\Customs\Tools\PyMS\PyGRP.pyw", line 553, in preview
   self.frameoutline()
 File "D:\Libraries\Gaming\StarCraft_Content\Customs\Tools\PyMS\PyGRP.pyw", line 528, in frameoutline
   x1,y1,x2,y2 = self.grp.images_bounds[frame]
IndexError: list index out of range


Additionally, while I was working with a *.grp:

1) I opened the grp file ORIGINAL. (ORIGINAL happens to be Kakaru, neutral critter in Twilight, the bird thing.)
2) I deleted every frame except for its death animation, from top to bottom in the frame list using keyboard shortcut DELETE.
3) I used SAVE AS to save to file OUT.
4) Expected output: file OUT retains remaining frames (death animation) and frames are complete. Actual output: file OUT retains remaining frames but frames are not complete: frames have been cropped according to the limits drawn in the file ORIGINAL and by the "Frame Outline (Red)" feature.
These were all a result of the same issues, and they have been fixed. Thanks!



Quote from Neiv
2) Saving grp causes another crash:
Code
Exception in Tkinter callback
Traceback (most recent call last):
 File "C:\Ohjelmia\Python27\lib\lib-tk\Tkinter.py", line 1532, in __call__
   return self.func(*args)
 File "C:\Pelei\Scbw\Ohjelmia\PyMS\PyGRP.pyw", line 683, in save
   self.grp.save_file(self.file)
 File "C:\Pelei\Scbw\Ohjelmia\PyMS\Libs\GRP.py", line 457, in save_file
   f.close()
 File "C:\Pelei\Scbw\Ohjelmia\PyMS\Libs\utils.py", line 1447, in close
   raise e
WindowsError: [Error 183] Cannot create file, already exists

Nvm, another program didn't let it save
I've made the error more graceful, thanks!



Quote from Neiv
3) Grps are encoded inefficiently: Every non-transparent color is encoded as [repeat this color for n pixels], even if there are no vertical lines of repeated colors. Not too huge deal but happened to notice it
I re-wrote the compression so it should be back to having the highest compression. Thanks!



Quote from Neiv
Edit: 4) Opening and saving again loses the last row/column of each frame
I believe this is fixed, Thanks!




Oct 24 2015, 6:21 pm Sand Wraith Post #59

she/her

The new PyGRP seems to corrupt files. The corruption is visible on inspection in PyGRP.




Oct 25 2015, 5:00 am poiuy_qwert Post #60

PyMS and ProTRG developer

Quote from Sand Wraith
The new PyGRP seems to corrupt files. The corruption is visible on inspection in PyGRP.
Can you provide sample bmp's or a grp to open+resave that reproduces the corruption?




Options
Pages: < 1 2 3 4 523 >
  Back to forum
Please log in to reply to this topic or to report it.
Members in this topic: None.
[11:50 pm]
O)FaRTy1billion[MM] -- nice, now i have more than enough
[11:49 pm]
O)FaRTy1billion[MM] -- if i don't gamble them away first
[11:49 pm]
O)FaRTy1billion[MM] -- o, due to a donation i now have enough minerals to send you minerals
[2024-4-17. : 3:26 am]
O)FaRTy1billion[MM] -- i have to ask for minerals first tho cuz i don't have enough to send
[2024-4-17. : 1:53 am]
Vrael -- bet u'll ask for my minerals first and then just send me some lousy vespene gas instead
[2024-4-17. : 1:52 am]
Vrael -- hah do you think I was born yesterday?
[2024-4-17. : 1:08 am]
O)FaRTy1billion[MM] -- i'll trade you mineral counts
[2024-4-16. : 5:05 pm]
Vrael -- Its simple, just send all minerals to Vrael until you have 0 minerals then your account is gone
[2024-4-16. : 4:31 pm]
Zoan -- where's the option to delete my account
[2024-4-16. : 4:30 pm]
Zoan -- goodbye forever
Please log in to shout.


Members Online: X405, Oh_Man